fix: default to local platform, use docker additional-args Quarkus flag #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jankalinic I think this should also work on Mac, but when you have time can you check? This is low priority. |
|
Sure, i can put it on my todo. Thanks for letting me know about this PR. |
|
But if you are okay with quick check it returns |
Signed-off-by: Michael Edgar <[email protected]>
MikeEdgar
force-pushed
the
makefile-platforms
branch
from
6c2e3a9 to
6518f89
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLATFORMSin Makefile to just the current native platform.QUARKUS_DOCKER_ADDITIONAL_ARGSinstead ofQUARKUS_DOCKER_BUILDX_PLATFORM(does not work with podman)